Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: get rid of bootstrap #3784

Merged
merged 1 commit into from
Dec 5, 2024
Merged

ui: get rid of bootstrap #3784

merged 1 commit into from
Dec 5, 2024

Conversation

jma
Copy link
Contributor

@jma jma commented Nov 21, 2024

No description provided.

@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: user management f: data migration Data migration from a legacy system or a previous version labels Nov 21, 2024
@jma jma changed the title in progress ui: get rid of bootstrap Nov 21, 2024
@PascalRepond

This comment was marked as resolved.

Sign in to view
@PascalRepond

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the developers From a developer point of view. label Nov 28, 2024
@PascalRepond
Copy link
Contributor

PascalRepond commented Dec 3, 2024 •
edited by jma
Loading

Tests (pass 3)

  • REP: Description in doc detail view -> table should be striped for readability
  • REP: Message "Please make sure that your requested issue is not listed above." Should be in a yellow box (warning)
  • REP: Interlibrary loan button, should only be displayed in the global view (not organisation viewcode) and it should be outline.
    • nice-to-have: this button could have an icon fa-truck
  • REP: "Send to" heading is not necessary
    • Center the icons in the button
      image
    • RIS button should be icon "file-text-o"
  • REP: Files -> there is now an expand button in the file preview window but it doesn't work properly
    image
  • REP: (not-blocking), when opening a doc detail view that has babelio, the Babelio message loads first for a second (example: https://ilsdev.test.rero.ch/aoste/documents/2001717)

@jma jma force-pushed the maj-primeng branch 5 times, most recently from abc3b81 to 0e9da44 Compare December 4, 2024 08:21
@jma jma changed the base branch from staging to next-version December 4, 2024 08:22
@jma jma marked this pull request as ready for review December 4, 2024 08:22
@jma jma requested review from rerowep and Garfield-fr December 4, 2024 08:22
@jma jma force-pushed the maj-primeng branch 2 times, most recently from 4245d50 to 767e332 Compare December 4, 2024 08:30
@jma
ui: uses primeng for the frontend
1f9caa4 
* Adds missing format alias on the the REST API.
* Adds placeholder on the contries editor.
* All document detailed view tabs is done in angular.
* Removes useless document views.
* Removes useless document jinja template filters and their corresponding tests.
* Adds layer to css styles to avoid primeng and bootstrap conflicts.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma merged commit a557424 into rero:next-version Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@rerowep rerowep rerowep approved these changes

Assignees

@jma jma

Labels
developers From a developer point of view. f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jma @PascalRepond @Garfield-fr @rerowep