Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search: Replace AND default operator by OR. #401

Merged
merged 1 commit into from
Jul 16, 2019
Merged

search: Replace AND default operator by OR. #401

merged 1 commit into from
Jul 16, 2019

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Jul 12, 2019 •
edited
Loading

  • Adds a new display_score url parameters display_score=1.
  • Restore OR default search operator, closes Search with AND operator does not work as expected. #384.
  • Improves Elasticsearch mappings and JSONSchema for documents:
    • two JSONSchema: one minimal for havested records and one for
      internal record.
    • unique elasticsearch mapping
  • Put cantook and internal records in the same Elasticsearch index.
  • Improves search page layout.
  • Improves serializers permissions, closes Should ebooks records be editable ? #89.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

To Test

  • script/bootstrap
  • script/setup
  • add display_score=1 to a search query URL

@Garfield-fr Garfield-fr requested review from BadrAly and reropag July 12, 2019 13:45
@Garfield-fr Garfield-fr force-pushed the maj-issue-384-and-search-operator branch from a2cdfb8 to 7a7543c Compare July 12, 2019 13:49
@Garfield-fr Garfield-fr requested a review from pronguen July 15, 2019 13:33
@Garfield-fr Garfield-fr force-pushed the maj-issue-384-and-search-operator branch from 7a7543c to 8e6d698 Compare July 15, 2019 13:38
BadrAly
BadrAly approved these changes Jul 16, 2019
View reviewed changes
Copy link

@BadrAly BadrAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not harvested_pid instead of harvestedID as all the IDS in rero_ils

@Garfield-fr Garfield-fr force-pushed the maj-issue-384-and-search-operator branch from 8e6d698 to 6987d5f Compare July 16, 2019 08:12
@jma @Garfield-fr
search: Replace AND default operator by OR.
f5b0f93 
* Adds a new display_score url parameters `display_score=1`.
* Restore OR default search operator, closes rero#384.
* Improves Elasticsearch mappings and JSONSchema for documents:
  * two JSONSchema: one minimal for havested records and one for
  internal record.
  * unique elasticsearch mapping
* Put cantook and internal records in the same Elasticsearch index.
* Improves search page layout.
* Improves serializers permissions, closes rero#89.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the maj-issue-384-and-search-operator branch from 6987d5f to f5b0f93 Compare July 16, 2019 08:13
@Garfield-fr Garfield-fr merged commit b05eb74 into rero:dev Jul 16, 2019
@Garfield-fr Garfield-fr deleted the maj-issue-384-and-search-operator branch July 16, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BadrAly BadrAly BadrAly approved these changes

@pronguen pronguen pronguen approved these changes

@reropag reropag Awaiting requested review from reropag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garfield-fr @pronguen @BadrAly @jma