Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: compact the presentation #434

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Conversation

jma
Copy link
Contributor

@jma jma commented Aug 8, 2019

  • Improves editor appearance.
  • Improves js package manager: use yarn instead of npm.
  • Save vertical space by putting add item in menu

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

To Test

  • boostrap

Note

Do not forget to clear your cache.

@jma jma force-pushed the maj-cataloging-#928 branch 2 times, most recently from 78bdbf8 to f82c502 Compare August 8, 2019 15:08
@jma jma changed the title editor: compact the presenation editor: compact the presentation Aug 8, 2019
@jma jma force-pushed the maj-cataloging-#928 branch from f82c502 to a63b73e Compare August 8, 2019 15:19
Copy link
Contributor

@rerowep rerowep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using webpack as invenio does?

Some warnings:

yarn install v1.17.3
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning " > ngx-toggle-switch@2.0.5" has incorrect peer dependency "@angular/core@>=5.0.0 <=6.0.0".
warning " > ngx-toggle-switch@2.0.5" has incorrect peer dependency "@angular/common@>=5.0.0 <=6.0.0".
warning " > ngx-toggle-switch@2.0.5" has incorrect peer dependency "rxjs@^5.4.0".

Help address not working: http://localhost:5000/cataloging/help

Boxes are displayed strangely (bottom line)

@jma jma force-pushed the maj-cataloging-#928 branch 2 times, most recently from 3425231 to 09b192c Compare August 12, 2019 15:54
@jma jma requested a review from pronguen August 13, 2019 06:37
@jma
Copy link
Contributor Author

jma commented Aug 13, 2019

Why not using webpack as invenio does?

This requires to publish our angular module on npm. Will be done in the future.

Some warnings:

yarn install v1.17.3
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning " > ngx-toggle-switch@2.0.5" has incorrect peer dependency "@angular/core@>=5.0.0 <=6.0.0".
warning " > ngx-toggle-switch@2.0.5" has incorrect peer dependency "@angular/common@>=5.0.0 <=6.0.0".
warning " > ngx-toggle-switch@2.0.5" has incorrect peer dependency "rxjs@^5.4.0".

We are aware of that will be addressed in a other PR.

Help address not working: http://localhost:5000/cataloging/help

You are right, but this will be probably provided by the PO, in the next sprint.

Boxes are displayed strangely (bottom line)
Solved.

@jma jma requested a review from rerowep August 13, 2019 11:53
Copy link
Contributor

@pronguen pronguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • For identifiedBy, the subfield Source is not displayed, even if it contains a value (example). Is it normal?
  • Is it possible, for text fields with long values like title (example), to bring the text to a new line and enlarge vertically the input field?
  • When clicking on "Submit" to save a document, system should display the document detailed view, and the editor should disappear. Currently, it saves the document but the editor stays open.
  • When I add a language value or a title proper (for example) then save the record and try to edit the same document again, I cannot edit the two added fields. They are not displayed in the editor. If I save a second time, the data is lost.
  • When I add an author section and start filling one of the fields below Type, the field Type disappears.
  • We could disable the Help menu entry.

To keep in mind for later:

  • For field identifiedBy.type, we will want to display other labels for the end user.
  • We will want to hide field language.type.

@jma
Copy link
Contributor Author

jma commented Aug 19, 2019

  • For identifiedBy, the subfield Source is not displayed, even if it contains a value (example). Is it normal?
    Yes. This will be done later as we have plenty of subfield for identifiedBy.
  • Is it possible, for text fields with long values like title (example), to bring the text to a new line and enlarge vertically the input field?
    Can be done for paragraph based data such as abstracts, notes. Needs to investigate how to deal with long titles.
  • When clicking on "Submit" to save a document, system should display the document detailed view, and the editor should disappear. Currently, it saves the document but the editor stays open.
    This was also the case before this PR. However, I did it.
  • When I add a language value or a title proper (for example) then save the record and try to edit the same document again, I cannot edit the two added fields. They are not displayed in the editor. If I save a second time, the data is lost.
    I was unable to reproduce this.
  • When I add an author section and start filling one of the fields below Type, the field Type disappears.
    It is a normal behaviour. This can be reviewed when the author will be specified by the metadata group.
  • We could disable the Help menu entry.
    Done.

To keep in mind for later:

  • For field identifiedBy.type, we will want to display other labels for the end user.
    Done. A list should be provided, for the moment I removed the prefix.
  • We will want to hide field language.type.
    Done.

@jma jma force-pushed the maj-cataloging-#928 branch 6 times, most recently from 51bc3d2 to a3b4dde Compare August 22, 2019 08:58
* Improves editor appearance.
* Improves js package manager: use yarn instead of npm.
* Save vertical space by putting add item in menu

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-cataloging-#928 branch 2 times, most recently from f0727ac to c3ac14b Compare August 22, 2019 09:04
@jma jma requested a review from iGormilhit August 22, 2019 09:26
@jma jma changed the base branch from dev to US911-cataloging August 26, 2019 08:22
@jma jma merged commit 9b6ed1c into rero:US911-cataloging Aug 26, 2019
@jma jma deleted the maj-cataloging-#928 branch December 11, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants