-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editor: compact the presentation #434
Conversation
78bdbf8
to
f82c502
Compare
f82c502
to
a63b73e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using webpack
as invenio
does?
Some warnings:
yarn install v1.17.3
[1/4] 🔍 Resolving packages...
[2/4] 🚚 Fetching packages...
[3/4] 🔗 Linking dependencies...
warning " > ngx-toggle-switch@2.0.5" has incorrect peer dependency "@angular/core@>=5.0.0 <=6.0.0".
warning " > ngx-toggle-switch@2.0.5" has incorrect peer dependency "@angular/common@>=5.0.0 <=6.0.0".
warning " > ngx-toggle-switch@2.0.5" has incorrect peer dependency "rxjs@^5.4.0".
Help address not working: http://localhost:5000/cataloging/help
Boxes are displayed strangely (bottom line)
3425231
to
09b192c
Compare
This requires to publish our angular module on npm. Will be done in the future.
We are aware of that will be addressed in a other PR.
You are right, but this will be probably provided by the PO, in the next sprint.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- For identifiedBy, the subfield Source is not displayed, even if it contains a value (example). Is it normal?
- Is it possible, for text fields with long values like title (example), to bring the text to a new line and enlarge vertically the input field?
- When clicking on "Submit" to save a document, system should display the document detailed view, and the editor should disappear. Currently, it saves the document but the editor stays open.
- When I add a language value or a title proper (for example) then save the record and try to edit the same document again, I cannot edit the two added fields. They are not displayed in the editor. If I save a second time, the data is lost.
- When I add an author section and start filling one of the fields below Type, the field Type disappears.
- We could disable the Help menu entry.
To keep in mind for later:
- For field identifiedBy.type, we will want to display other labels for the end user.
- We will want to hide field language.type.
|
51bc3d2
to
a3b4dde
Compare
* Improves editor appearance. * Improves js package manager: use yarn instead of npm. * Save vertical space by putting add item in menu Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
f0727ac
to
c3ac14b
Compare
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
To Test
Note
Do not forget to clear your cache.