Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: facet language translation #435

Merged
merged 1 commit into from
Aug 12, 2019
Merged

ui: facet language translation #435

merged 1 commit into from
Aug 12, 2019

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Aug 9, 2019 •
edited
Loading

  • Adds facet language translation

How to test:

  • script/bootstrap

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

@Garfield-fr
ui: facet language translation
80b93aa 
* Adds facet language translation

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr requested review from jma, BadrAly and rerowep August 9, 2019 11:33
rerowep
rerowep requested changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@rerowep rerowep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not working for italien:

 lingua
fre (17265)
ger (3700)
eng (2415)
ita (639)
jpn (206)
chi (204)
rus (203)
ara (200)
lat (176)
spa (172)

@rerowep rerowep self-requested a review August 9, 2019 13:59
@iGormilhit iGormilhit merged commit 6cc601a into rero:US912-Data_model Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerowep rerowep rerowep approved these changes

@BadrAly BadrAly BadrAly approved these changes

@jma jma Awaiting requested review from jma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garfield-fr @BadrAly @rerowep @iGormilhit