-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editor: shows/hides main (1th level) fields #473
Conversation
c9c9bc0
to
50d69db
Compare
50d69db
to
2646208
Compare
5277bf9
to
9d902df
Compare
9d902df
to
5d017de
Compare
2646208
to
daaa18e
Compare
daaa18e
to
8102c52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typos in commit message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problems:
- In 2nd-level fields, selecting text with the mouse is not possible. However, it is possible in the 1st-level fields.
- Repetitive subfields (publisher.name, publisher.place) are not fully displayed in the editor: only one is displayed.
- Existing ISBN are displayed in the detailed view, but if I edit a record, it disappears from the detailed view (same if I create a new record).
- When adding a second "language", the key "type" (hidden in the form) is not added and the form cannot be validated and saved.
Improvements:
- When adding a subfield with the "plus" or when adding a field listed in the top section, place the mouse cursor directly in the new input box.
- When adding a field listed in the top section, display the form so that the newly added field is visible.
- In the top section (add fields), list all kind of fields that can be added, even those already in the form that are repetitive.
- Some constraints should be added for the field "identifiedBy":
- "source" exists only if type=bf:Local and is in this case required
- "acquisitionsTerms" exists only if type=bf:Isbn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes in the commit message:
editor: shows/hides main (1st level) fields
* Adds buttons to editor to hide or show optional fields.
* With initial data, populated fields are displayed, empty fields are
hidden.
* All document fields are available in the editor.
* Fixes language and identifiedBy fields for BNF importation.
c2c0835
to
155a3f3
Compare
* Adds buttons to editor to hide or show optional fields. * With initial data, populated fields are displayed, empty fields are hidden. * All document fields are available in the editor. * Fixes language and identifiedBy fields for BNF importation. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
155a3f3
to
168cd9a
Compare
Done |
Not fixed, you can open an issue if you want.
This is an issue of the editor library. An issue has been opened: hamzahamidi/ajsf#144
Fixed.
Fixed.
Done but required part (not possible with the actual version of jsonschema as I know).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase with dev
please for faster deployment!
hidden.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch