publication statement bnf #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerowep
requested review from
Garfield-fr,
jma,
blankoworld,
BadrAly,
AoNoOokami and
reropag
BadrAly
suggested changes
Sep 13, 2019
rerowep
force-pushed
the
wep-#1018-publication-statement-bnf
branch
10 times, most recently
from
4384dc5 to
fae3a6c
Compare
iGormilhit
reviewed
Sep 18, 2019
There was a problem hiding this comment.
I know it's WIP, but some points about the commit message:
data model: implement publication statement transformation for BNF
* implements publication statement transformation for BNF
Co-Authored-by: Peter Weber <peter.weber@rero.ch>
No signed off, please. Do not forget <> around e-mail addresses. Verb without s in the title, but with s in the body. If the body add no further information to the title, maybe it's not needed.
rerowep
force-pushed
the
wep-#1018-publication-statement-bnf
branch
2 times, most recently
from
67b9a46 to
949cb6a
Compare
rerowep
force-pushed
the
wep-#1018-publication-statement-bnf
branch
2 times, most recently
from
d1afba2 to
b2f788e
Compare
AoNoOokami
approved these changes
Sep 18, 2019
rerowep
force-pushed
the
wep-#1018-publication-statement-bnf
branch
3 times, most recently
from
6cec27d to
ab91507
Compare
rerowep
force-pushed
the
wep-#1018-publication-statement-bnf
branch
3 times, most recently
from
823fa9d to
c9ce7a7
Compare
rerowep
force-pushed
the
US931-data-model-publication-statement
branch
from
874ccf6 to
b40a8ae
Compare
rerowep
force-pushed
the
wep-#1018-publication-statement-bnf
branch
from
c9ce7a7 to
35d76ce
Compare
jma
requested changes
Sep 19, 2019
rero_ils/modules/documents/dojson/contrib/unimarctojson/model.py
Outdated
Show resolved
Hide resolved
rerowep
force-pushed
the
wep-#1018-publication-statement-bnf
branch
from
35d76ce to
ed17c45
Compare
BadrAly
suggested changes
Sep 19, 2019
* Implements the publication statement transformation for BNF. * Adds base class for marc dojson transformation. * Adds colored message functions to `setup` and `bootstrup` scripts Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep
force-pushed
the
wep-#1018-publication-statement-bnf
branch
from
ed17c45 to
e1ed65f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to import a BNF record