metadata: fix dojson for virtua records #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerowep
force-pushed
the
wep-#1069-extract-virtua-bib-records
branch
19 times, most recently
from
c7098a1 to
0a29dc1
Compare
rerowep
force-pushed
the
wep-#1069-extract-virtua-bib-records
branch
10 times, most recently
from
4a8a764 to
3e62499
Compare
rerowep
force-pushed
the
wep-#1069-extract-virtua-bib-records
branch
12 times, most recently
from
a470615 to
66e9e7c
Compare
rerowep
force-pushed
the
wep-#1069-extract-virtua-bib-records
branch
from
66e9e7c to
ac3fdb2
Compare
jma
changed the title
jma
approved these changes
Nov 7, 2019
rerowep
force-pushed
the
wep-#1069-extract-virtua-bib-records
branch
4 times, most recently
from
c3690c2 to
b17c121
Compare
BadrAly
suggested changes
Nov 7, 2019
There was a problem hiding this comment.
- Commit message missing information about the
cliandloancode changes. - [not very important] The error files generated after running the
setuporvalidate_jsoncli are placed by default in $DATA_PATH. Can these files be generated outside of the project? so they do not listed in the project changed files when you rungit status.
rerowep
force-pushed
the
wep-#1069-extract-virtua-bib-records
branch
from
b17c121 to
db52648
Compare
rerowep
force-pushed
the
wep-#1069-extract-virtua-bib-records
branch
from
db52648 to
cbe541d
Compare
* Fixes dojson transformation errors. * Adds data path parameter to setup script. * Adds all languages to documents json schema and form. * Adds marc21tojson utils cli for parallel dojson transformation. * Adds lazy loading of json records from file. * Adds exception handlung for record creation. * Adds pids to documents_big.json and documents.small.json. * Better loading of loans with exception handling. Co-Authored-by: Peter Weber <peter.weber@rero.ch> Co-Authored-by: Gianni Pante <gianni.pante@rero.ch>
rerowep
force-pushed
the
wep-#1069-extract-virtua-bib-records
branch
from
cbe541d to
2d93e6b
Compare
I have added commit message for the loan. The cli was already in the commit messages. |
BadrAly
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Peter Weber peter.weber@rero.ch
Why are you opening this PR?
How to test?
pipenv run invenio utils marc21tojson data/documents_big.xml big_ok.json big_errors.xml -v -c 100Code review check list