Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixtures: reset sequence to correct value after loading records #561

Merged
merged 1 commit into from
Oct 16, 2019
Merged

fixtures: reset sequence to correct value after loading records #561

merged 1 commit into from
Oct 16, 2019

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Oct 15, 2019 •
edited
Loading

Co-Authored-by: Aly Badr aly.badr@rero.ch

Why are you opening this PR?

  • To fix issue when sequence is not updated after fixtures record loading

How to test?

  • scripts/setup
  • check that sequences are up to date (pgAdmin4)

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@BadrAly BadrAly force-pushed the fix-append-sequence branch from d3228ae to ddf7d1f Compare October 15, 2019 08:55
@BadrAly BadrAly requested a review from iGormilhit October 15, 2019 08:56
@BadrAly BadrAly force-pushed the fix-append-sequence branch 4 times, most recently from 75df044 to 3c9d0f6 Compare October 15, 2019 12:01
@BadrAly BadrAly force-pushed the fix-append-sequence branch 2 times, most recently from 97f0495 to e0bbef8 Compare October 16, 2019 07:02
rerowep
rerowep reviewed Oct 16, 2019
View reviewed changes
rero_ils/modules/cli.py Outdated Show resolved Hide resolved
@BadrAly BadrAly force-pushed the fix-append-sequence branch from e0bbef8 to f87f1b2 Compare October 16, 2019 07:15
fixtures: reset sequence to correct value after loading records
5944e06 
* Closes rero#563

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly force-pushed the fix-append-sequence branch from f87f1b2 to 5944e06 Compare October 16, 2019 07:25
@BadrAly BadrAly requested a review from rerowep October 16, 2019 10:54
@iGormilhit iGormilhit merged commit fa62e43 into rero:dev Oct 16, 2019
@BadrAly BadrAly deleted the fix-append-sequence branch August 24, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@blankoworld blankoworld blankoworld approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@jma jma Awaiting requested review from jma

@rerowep rerowep Awaiting requested review from rerowep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BadrAly @Garfield-fr @blankoworld @iGormilhit @rerowep