ui: fix global homepage #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
force-pushed
the
zaa-#1083-global-homepage
branch
3 times, most recently
from
aac2df0 to
88173bc
Compare
AoNoOokami
requested review from
iGormilhit,
blankoworld,
Garfield-fr,
BadrAly,
jma and
rerowep
AoNoOokami
force-pushed
the
zaa-#1083-global-homepage
branch
2 times, most recently
from
e601579 to
b70fd23
Compare
AoNoOokami
force-pushed
the
zaa-#1083-global-homepage
branch
from
b70fd23 to
b9543f1
Compare
jma
approved these changes
Oct 22, 2019
AoNoOokami
force-pushed
the
zaa-#1083-global-homepage
branch
from
b9543f1 to
13b4c6a
Compare
|
Rebased to dev |
* Adds homepage to global homepage redirection * Adds test help on homepage * Closes rero#475 Co-Authored-by: Alicia Zangger <aliciazangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-#1083-global-homepage
branch
from
13b4c6a to
f6174f5
Compare
BadrAly
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger aliciazangger@rero.ch
Why are you opening this PR?
Implements task 1083 of US 1082
Closes #475
How to test?
Clone PR
cd rero-ilsgit fetch rero pull/570/head:PR570git checkout PR570Test global homepage
localhost:5000/global should redirect to localhost:5000
Check test help is displayed according to the mockup
Code review check list