persons: fix filter to get documents in organisation views #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benerken
changed the title
AoNoOokami
approved these changes
Oct 28, 2019
zannkukai
approved these changes
Oct 28, 2019
iGormilhit
suggested changes
Oct 30, 2019
There was a problem hiding this comment.
Commit message: reference to the taiga task is not needed. And try to be more specific:
persons: fix filter to get documents in person view
* Uses correct filter (holdings in place of items)
to display documents list in person detailed views
filtered by organisation views.
* Closes #553
Or something like that. Thanks.
* Uses correct filter (holdings in place of items) to display documents list in person detailed views filtered by organisation views. * Closes rero#553 Co-Authored-by: Benoit Erken erken.benoit@gmail.com
benerken
force-pushed
the
ucl-#1109-person-page-no-link-to-document
branch
from
0eb928d to
dbaca37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
to display documents list in person detailed views
filtered by organisation views.
Co-Authored-by: Benoit Erken erken.benoit@gmail.com
How to test?
Code review check list