translation: fix user message when an item is requested #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
ucl-#1108-translation-item-requested
branch
from
b5d7c3d
to
db50493
Compare
iGormilhit
suggested changes
Oct 30, 2019
* Fixes translation string "the item has been requested" with variable item_id. * Closes rero#404. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
ucl-#1108-translation-item-requested
branch
from
db50493
to
50d0a19
Compare
jma
requested changes
Oct 31, 2019
| @@ -2477,98 +2477,58 @@ msgstr "" | |||
| msgid "Software under development" | |||
| msgstr "" | |||
|
|
|||
| #: rero_ils/templates/rero_ils/frontpage.html:78 | |||
There was a problem hiding this comment.
This does not come from your PR. It seems that translations are not up to date. Can you check that we do not loose translations from transifex. You have similar cases latter in this file.
|
You can the githup spelling correction in you commit message. |
zannkukai
changed the title
jma
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Additional informations
frontpagetemplate ('H' should be in uppercase)How to test?
Code review check list