Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: hide "No issues detected!" from autoflake #595

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

blankoworld
Copy link
Contributor

@blankoworld blankoworld commented Oct 31, 2019

Co-Authored-by: Olivier DOSSMANN git@dossmann.net

Why are you opening this PR?

"No issues detected!" appears a lot while running tests

How to test?

Bootstrap an instance, then launch server and then:

./run-tests.sh

You can also add useless imports in Python files and then launch ./run-tests.sh again to see a message like:

Use this command to check imports:                                                                                                                      
        autoflake --remove-all-unused-imports -r --exclude ui --ignore-init-module-imports .

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

run-tests.sh Outdated Show resolved Hide resolved
Co-Authored-by: Olivier DOSSMANN <git@dossmann.net>
@blankoworld blankoworld force-pushed the doo-hide-autoflake-report branch from 14b84a2 to d06003d Compare October 31, 2019 14:17
@AoNoOokami AoNoOokami self-requested a review November 5, 2019 07:50
@blankoworld blankoworld merged commit 34f7c65 into rero:dev Nov 6, 2019
@blankoworld blankoworld deleted the doo-hide-autoflake-report branch March 30, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants