Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new document types #63

Merged
merged 2 commits into from
Aug 9, 2018
Merged

add new document types #63

merged 2 commits into from
Aug 9, 2018

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Aug 8, 2018

This commit concern the taiga task 608, taiga task 609, taiga task 611

  • update populate
  • new data export

ℹ️ See pull request reroils-data rero/reroils-data-legacy#43

Igor Milhit and others added 2 commits August 7, 2018 14:50
Signed-off-by: Igor Milhit <igor.milhit@rero.ch>
Co-authored-by: Nicolas Labat <nicolas.labat@rero.ch>
- update populate
- new data export

Signed-off-by: Peter Weber <Peter.Weber@rero.ch>
Co-authored-by: Igor Milhit <Igor.Milhit@rero.ch>
Co-authored-by: Nicolas Labat <Nicolas.Labat@rero.ch>
@BadrAly
Copy link

BadrAly commented Aug 8, 2018

  • Must drop the old index "documents-book-v0.0.1" in order for the populate to work
    invenio index delete --force --yes-i-know documents-book-v0.0.1 || true

@BadrAly
Copy link

BadrAly commented Aug 8, 2018

Not really a problem but in case you have the time to fix this:
data/10k.json: Bad indentation

@BadrAly BadrAly self-requested a review August 8, 2018 15:06
@rerowep
Copy link
Contributor Author

rerowep commented Aug 8, 2018 via email

@iGormilhit
Copy link

iGormilhit commented Aug 9, 2018

@rerowep invenio utils check_json data/10k.json -r should do it.

@jma jma merged commit 0fe7fb5 into rero:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants