translation: fix patron form editor translation problem #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
requested review from
jma,
BadrAly,
benerken,
blankoworld,
iGormilhit,
lauren-d and
pronguen
* Fixes translations problems on fields 'communication_channel' and 'communication_language' in the patron form definition * Closes rero#572 Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-fix-patron-form-translation-problem
branch
from
ac3b734 to
bdc0d9c
Compare
lauren-d
approved these changes
Dec 11, 2019
rerowep
approved these changes
Dec 12, 2019
benerken
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite 'titleMap' definitions from "communication_channel" and "communication_language". Now, the label are translated to current interface language.
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
How to test?
Code review check list