circulation policy: ignore settings when deleting a policy #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
approved these changes
Dec 13, 2019
rerowep
approved these changes
Dec 13, 2019
|
Actually, the issue related to this PR comes from rero-ils-ui: rero/rero-ils-ui#76. The issue mentioned in your commit message is this one: #76. Should we mention it this way in commit message: rero/rero-ils-ui#76 ? |
* Fixes an issue when cipo settings blocked its deletion. * Closes rero/rero-ils-ui#76 Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly
force-pushed
the
baa-#1215-cipo-settings
branch
from
b75d134 to
e2f8963
Compare
@AoNoOokami Done |
iGormilhit
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Aly Badr aly.badr@rero.ch
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/task/1215?kanban-status=1224894
How to test?
Code review check list