Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: fix objects indexation #678

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

blankoworld
Copy link
Contributor

Co-Authored-by: Olivier DOSSMANN git@dossmann.net

Why are you opening this PR?

Document indexation failed in rero-ils

How to test?

Launch ./script/setup.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

Copy link
Contributor

@rerowep rerowep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct: rero_ils.modules.items.cli.py line 103
-- documents_pids = Document.get_all_pids()
++ documents_pids = list(Document.get_all_pids())

We still have problems to create all loans correctly.
We have to find a bullet proof way to create item and holdings satisfying loan conditions!

Maybe recreate item/holdings small/big fixtures:
./scripts/setup --create_items_holdings_small
./scripts/setup --create_items_holdings_big

scripts/setup Show resolved Hide resolved
scripts/setup Outdated Show resolved Hide resolved
scripts/setup Show resolved Hide resolved
scripts/setup Outdated Show resolved Hide resolved
@blankoworld
Copy link
Contributor Author

correct: rero_ils.modules.items.cli.py line 103
-- documents_pids = Document.get_all_pids()
++ documents_pids = list(Document.get_all_pids())

We still have problems to create all loans correctly.
We have to find a bullet proof way to create item and holdings satisfying loan conditions!

Maybe recreate item/holdings small/big fixtures:
./scripts/setup --create_items_holdings_small
./scripts/setup --create_items_holdings_big

Seems to be done here: 365ba62#diff-a77cff7ca3f93ecb6be6a0b87aca473eR105
Do you confirm @rerowep ?

* Changes setup display

Co-Authored-by: Olivier DOSSMANN <git@dossmann.net>
@blankoworld blankoworld requested a review from rerowep January 9, 2020 11:32
@blankoworld blankoworld removed the WIP label Jan 9, 2020
@blankoworld blankoworld merged commit c2ce015 into rero:dev Jan 10, 2020
@blankoworld blankoworld deleted the doo-fix-setup-index branch March 30, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants