budget: update entities budget and acq_account for new formly component #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
requested review from
BadrAly,
zannkukai,
jma,
benerken,
lauren-d and
rerowep
BadrAly
approved these changes
Jan 10, 2020
Garfield-fr
force-pushed
the
zub-budget-formly
branch
from
ba2255c
to
0349ff9
Compare
7 tasks
Garfield-fr
force-pushed
the
zub-budget-formly
branch
2 times, most recently
from
d87b011
to
be8189f
Compare
Garfield-fr
force-pushed
the
zub-budget-formly
branch
3 times, most recently
from
44fb708
to
d94c5b4
Compare
lauren-d
approved these changes
Jan 16, 2020
iGormilhit
suggested changes
Jan 16, 2020
rero_ils/modules/acq_accounts/jsonschemas/acq_accounts/acq_account-v0.0.1.json
Outdated
Show resolved
Hide resolved
rero_ils/modules/budgets/jsonschemas/budgets/budget-v0.0.1.json
Outdated
Show resolved
Hide resolved
rero_ils/modules/budgets/jsonschemas/budgets/budget-v0.0.1.json
Outdated
Show resolved
Hide resolved
* Updates budget and acq_account for formly. * Fixes translation for new options form. * Updates babel config to extract new label key. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-budget-formly
branch
from
d94c5b4
to
bd8d9ef
Compare
jma
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Why are you opening this PR?
Code review check list