Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: allow loading external script #767

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

Garfield-fr
Copy link
Contributor

Co-Authored-by: Peter Weber peter.weber@rero.ch
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • Check ebook images
  • Check load external script (googleanalytics) => Not error on console

Code review check list

  • Commit message template compliance.
  • Commit message without typos.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@rerowep rerowep added this to the v0.6.0 milestone Feb 18, 2020
@iGormilhit iGormilhit merged commit b1aa2fe into rero:dev Feb 19, 2020
@Garfield-fr Garfield-fr deleted the zub-fix-security-img branch February 19, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants