requests: place a request for a patron by a librarian #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
BadrAly
requested review from
jma,
AoNoOokami,
zannkukai,
benerken,
blankoworld,
lauren-d,
rerowep and
sebdeleze
jma
requested changes
Mar 5, 2020
* Removes duplicate fixtures function. Co-Authored-by: Aly Badr <aly.badr@rero.ch>
* Removes duplicate fixtures function. * Adds sort on pickup_name location Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch> Co-Authored-by: Aly Badr <aly.badr@rero.ch>
jma
approved these changes
Mar 5, 2020
zannkukai
approved these changes
Mar 5, 2020
Comment on lines
+333
to
+339
| def can_request(item_pid, library_pid, patron_barcode): | ||
| """HTTP request to check if a librarian can request an item for a patron. | ||
|
|
||
| required_parameters: item_pid, library_pid, patron_barcode | ||
| """ | ||
| return is_librarian_can_request_item_for_patron( | ||
| item_pid, library_pid, patron_barcode) |
There was a problem hiding this comment.
Why don't using immediately is_librarian_can_request_item_for_patron or insert the code of this method into ?
benerken
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Co-Authored-by: Aly Badr aly.badr@rero.ch
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/us/657?milestone=257446
Code review check list