Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acquisition: cleanup useless functions of order lines resource #867

Merged
merged 1 commit into from
Apr 3, 2020
Merged

acquisition: cleanup useless functions of order lines resource #867

merged 1 commit into from
Apr 3, 2020

Conversation

lauren-d
Copy link
Contributor

Updates acquisition order lines resource to remove useless methods.

  • Removes methods from order lines resource api.

Co-Authored-by: Lauren-D laurent.dubois@itld-solutions.be

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@lauren-d lauren-d added the WIP label Mar 26, 2020
@lauren-d lauren-d self-assigned this Mar 26, 2020
@lauren-d lauren-d removed the WIP label Mar 26, 2020
@lauren-d lauren-d force-pushed the lau-fix-order-lines-useless-methods branch from aabc491 to f308c3c Compare March 31, 2020 09:04
jma
jma reviewed Apr 1, 2020
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand the commit message, sorry.

@lauren-d
acquisition: cleanup useless functions of order lines resource
577b428 
Updates acquisition order lines resource to remove useless methods.

* Removes useless function from order lines resource api.

Co-Authored-by: Lauren-D <laurent.dubois@itld-solutions.be>
@lauren-d lauren-d force-pushed the lau-fix-order-lines-useless-methods branch from f308c3c to 577b428 Compare April 1, 2020 13:03
@lauren-d
Copy link
Contributor Author

lauren-d commented Apr 1, 2020

I do not understand the commit message, sorry.

Commit message updated

@lauren-d lauren-d changed the title acquisition: fix order lines useless methods acquisition: cleanup useless functions of order lines resource Apr 1, 2020
@lauren-d lauren-d requested a review from jma April 1, 2020 13:30
@lauren-d lauren-d merged commit f8b3440 into rero:dev Apr 3, 2020
@lauren-d lauren-d deleted the lau-fix-order-lines-useless-methods branch August 19, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@BadrAly BadrAly BadrAly approved these changes

@benerken benerken benerken approved these changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma jma approved these changes

Assignees

@lauren-d lauren-d

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lauren-d @jma @zannkukai @benerken @BadrAly @AoNoOokami