test: fix external ones #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After wtforms 2.3.0, Travis encount problems in external tests. email_validator make an Exception as explained here: https://gitter.im/inveniosoftware/invenio?at=5ea0006df39e5c2fbb955db8 This commit avoid this problem by fixing wtforms to a version anterior to 2.3.0 * Adds your new feature. * Fixes an existing issue, may closes #issue. * Improves and existing feature. Co-Authored-by: Olivier DOSSMANN <git@dossmann.net>
blankoworld
force-pushed
the
doo-fix-wtforms-test
branch
from
d4bd2a8 to
ba9375d
Compare
zannkukai
approved these changes
Apr 22, 2020
rerowep
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After wtforms 2.3.0, Travis encount problems in external tests.
email_validator make an Exception as explained here:
https://gitter.im/inveniosoftware/invenio?at=5ea0006df39e5c2fbb955db8
This commit avoid this problem by fixing wtforms to a version anterior
to 2.3.0
Co-Authored-by: Olivier DOSSMANN git@dossmann.net
Why are you opening this PR?
Because of problems on our US1293-doo-invenio32 branch with tests: https://travis-ci.org/github/blankoworld/rero-ils/jobs/678065871#L683
Something like that happens:
As explained at invenio Gitter room, we should limit
wtformsto a version anterior to 2.3.0.How to test?
Just look after Travis tests. They should pass.
Code review check list