circulation: adapt reroils #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
force-pushed
the
baa-1431-adapt-reroils
branch
from
4fb8568 to
86d6bac
Compare
BadrAly
force-pushed
the
baa-1431-adapt-reroils
branch
2 times, most recently
from
722005d to
5dc5b74
Compare
zannkukai
reviewed
Apr 27, 2020
zannkukai
requested changes
Apr 27, 2020
BadrAly
force-pushed
the
baa-1431-adapt-reroils
branch
from
5dc5b74 to
b0bfecf
Compare
zannkukai
approved these changes
Apr 27, 2020
blankoworld
approved these changes
Apr 27, 2020
Adapts reroils after the upgrade to invenio-circulation v1.0.0a21. The two transitions ItemOnLoanToItemReturned and ItemOnLoanToItemReturned are temporarily updated and inserted into reroils until a fix for the issue inveniosoftware/invenio-circulation#127 is available. This PR expects the fix for the ITEM_AT_DESK problem in the current version of invenio-circulation. Some timezone units testing are disabled until a fix is given in a later PR. Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly
force-pushed
the
baa-1431-adapt-reroils
branch
from
b0bfecf to
4c4c1c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts reroils after the upgrade to invenio-circulation v1.0.0a21.
The two transitions ItemOnLoanToItemReturned and ItemOnLoanToItemReturned are
temporarily updated and inserted into reroils until a fix for the issue
inveniosoftware/invenio-circulation#127 is available.
This PR expects the fix for the ITEM_AT_DESK problem in the current version
of invenio-circulation.
Some timezone units testing are disabled until a fix is given in a later PR.
Co-Authored-by: Aly Badr aly.badr@rero.ch
Dependencies
This PR requires the
rero/invenio-circulation.item_at_deskbranchWhy are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/task/1431?kanban-status=1224894
How to test?
bootstrap + run_tests.shCode review check list