loans: fix automatic item assignment on pending loans #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes problem when the checked-in item will be assigned to all pending loans of its document. This PR needs rero/invenio-circulation/baa-1410-assign-item and rero/invenio-circulation/item_at_desk_temp * Fixes inveniosoftware/invenio-circulation#127. * Removes the temporary transitions file used as a work around earlier. Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem when the checked-in item will be assigned to all
pending loans of its document.
This PR needs rero/invenio-circulation/baa-1410-assign-item and
rero/invenio-circulation/item_at_desk_temp
Co-Authored-by: Aly Badr aly.badr@rero.ch
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/task/1410?kanban-status=1224893
How to test?
It is normal that travis tests fail here, only code review is required
Code review check list