Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document: suppress item detail view #970

Merged
merged 1 commit into from
May 6, 2020
Merged

document: suppress item detail view #970

merged 1 commit into from
May 6, 2020

Conversation

zannkukai
Copy link
Contributor

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

How to test?

  • logged as a librarian, go to a document detail view. All links to the item detail (previously on item barode) are now deleted.
  • same behavior when logged as a patron.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai self-assigned this Apr 30, 2020
@zannkukai zannkukai requested a review from rerowep April 30, 2020 11:31
@zannkukai zannkukai marked this pull request as ready for review April 30, 2020 11:31
rerowep
rerowep reviewed May 1, 2020
View reviewed changes
Copy link
Contributor

@rerowep rerowep left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document detailed view will change completely avec: #953 !

@iGormilhit
Copy link

iGormilhit commented May 4, 2020 •
edited
Loading

Document detailed view will change completely avec: #953 !

This PR is about public item detailed view, that we do not need anymore.

@iGormilhit iGormilhit self-requested a review May 4, 2020 07:05
iGormilhit
iGormilhit approved these changes May 4, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message is approved.

@zannkukai zannkukai force-pushed the zan-#delete-item-detailed-view branch from 36187bf to 2cf07d5 Compare May 5, 2020 08:04
@zannkukai
document: suppress item detail view
c2d6bdc 
* Deletes the item detail view in the public interface.
* Closes rero#884

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-#delete-item-detailed-view branch from 2cf07d5 to c2d6bdc Compare May 6, 2020 07:11
@rerowep rerowep self-requested a review May 6, 2020 07:32
@zannkukai zannkukai requested review from BadrAly and benerken May 6, 2020 07:33
@zannkukai zannkukai merged commit 6dfa9a7 into rero:dev May 6, 2020
@zannkukai zannkukai deleted the zan-#delete-item-detailed-view branch May 8, 2020 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerowep rerowep rerowep approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@BadrAly BadrAly Awaiting requested review from BadrAly

@benerken benerken Awaiting requested review from benerken

Assignees

@zannkukai zannkukai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suppress the item detailed view of the public interface
3 participants
@zannkukai @iGormilhit @rerowep