ebooks: fix holdings update when importing ebooks #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerowep
force-pushed
the
wep-#1478-ebook
branch
9 times, most recently
from
a41fcd1 to
d0d3fbd
Compare
rerowep
force-pushed
the
wep-#1478-ebook
branch
3 times, most recently
from
4c6491f to
ee5be1f
Compare
BadrAly
approved these changes
May 15, 2020
iGormilhit
suggested changes
May 18, 2020
jma
approved these changes
May 18, 2020
rero_ils/modules/ebooks/utils.py
Outdated
| ) | ||
|
|
||
| source_uris = [] | ||
| for harvested_source in harvested_sources: |
There was a problem hiding this comment.
you can use filter: https://book.pythontips.com/en/latest/map_filter.html#filter
|
|
||
| for holding_pid in Holding.get_holdings_pid_by_document_pid(pid): | ||
| holding = Holding.get_record_by_pid(holding_pid) | ||
| for electronic_location in holding.get('electronic_location', []): |
rerowep
changed the title
* Corrects creation, merging and deletetions of holding records for ebooks. Co-Authored-by: Peter Weber <peter.weber@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
How to test?
Code review check list