documents: fix partOf format

* Displays the issue and pages even if volume is not set.
* Closes #370.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>

sonar/modules/documents/views.py

@@ -173,13 +173,13 @@ def part_of_format(part_of):
         items.append('{label} {value}'.format(
             label=_('vol.'), value=part_of['numberingVolume']))
 
-        if 'numberingIssue' in part_of:
-            items.append('{label} {value}'.format(
-                label=_('no.'), value=part_of['numberingIssue']))
+    if 'numberingIssue' in part_of:
+        items.append('{label} {value}'.format(
+            label=_('no.'), value=part_of['numberingIssue']))
 
-        if 'numberingPages' in part_of:
-            items.append('{label} {value}'.format(
-                label=_('p.'), value=part_of['numberingPages']))
+    if 'numberingPages' in part_of:
+        items.append('{label} {value}'.format(
+            label=_('p.'), value=part_of['numberingPages']))
 
     return ', '.join(items)
 

tests/ui/documents/test_dc_schema.py

@@ -377,7 +377,7 @@ def test_sources(minimal_document):
     assert result['sources'] == [
         'Document 1, 2020',
         'Document 2, 2020, vol. 6, no. 12, p. 135-139',
-        'Document 3, 2019',
+        'Document 3, 2019, no. 12, p. 135-139',
     ]
 
 

tests/ui/documents/test_documents_views.py

@@ -207,7 +207,7 @@ def test_part_of_format():
         'numberingYear': '2015',
         'numberingIssue': '2',
         'numberingPages': '469-480'
-    }) == 'Mehr oder weniger Staat?, 2015'
+    }) == 'Mehr oder weniger Staat?, 2015, no. 2, p. 469-480'
 
     assert views.part_of_format({
         'numberingYear': '2015',