Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explode last name and first name for users. #222

Closed
sebdeleze opened this issue May 14, 2020 · 0 comments · Fixed by #445 or rero/sonar-ui#186
Closed

Explode last name and first name for users. #222

sebdeleze opened this issue May 14, 2020 · 0 comments · Fixed by #445 or rero/sonar-ui#186
Labels
enhancement Enhancement of an existing feature f: user management Related to users
Milestone
v1.0.0

Comments

@sebdeleze
Copy link
Contributor

I merged them for a bad reason (user's facet in deposit)..
I checked with ORCID and Switch edu-id and effectively we can get last name and first name separately.
@sebdeleze sebdeleze added 5 enhancement Enhancement of an existing feature labels Nov 30, 2020
@sebdeleze sebdeleze changed the title [3] Explode last name and first name for users. Explode last name and first name for users. Nov 30, 2020
@sebdeleze sebdeleze added this to the v1.0.0 milestone Nov 30, 2020
@sebdeleze sebdeleze added triage enhancement Enhancement of an existing feature f: user management Related to users and removed 5 enhancement Enhancement of an existing feature labels Jan 27, 2021
This was referenced Jan 27, 2021
Merged
Merged
sebdeleze pushed a commit to rero/sonar-ui that referenced this issue Jan 29, 2021
users: separate first name and last name.
4e7a04b 
* Changes all occurrences of `full_name` in templates.
* Closes rero/sonar#222.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
sebdeleze pushed a commit that referenced this issue Jan 29, 2021
users: separate first name and last name.
0ad13bb 
Separates first name and last in user's records. Before that, the first name and last name was stored in the same field (`full_name`).

* Updates JSON schemas and ES mapping and replaces `full_name` by `first_name` and `last_name`.
* Replaces `full_name` by `first_name` and `last_name` in serializers schemas.
* Adds `first_name` and `last_name` properties in users fixtures instead of `full_name`.
* Filters projects and deposits by `user.pid` instead of full name.
* Loads the name of the user during serialization of projects and deposits, to display it instead of the PID in aggregations.
* Changes all occurrences of `full_name` in emails and templates.
* Closes #222.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement of an existing feature f: user management Related to users
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

users: separate first name and last name.
users: separate first name and last name.
1 participant
@sebdeleze