Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The links of the table of content in the documentation are not working. #450

Closed
pronguen opened this issue Jan 27, 2021 · 1 comment · Fixed by #453
Closed

The links of the table of content in the documentation are not working. #450

pronguen opened this issue Jan 27, 2021 · 1 comment · Fixed by #453
Labels
bug Breaks something but is not blocking dev: documentation About changelog, release notes, installation procedures, gh templates...

Comments

@pronguen
Copy link
Contributor

In the help, there is a table of content to navigate inside a page. The links are not correct.

Example on this page: https://sonar.test.rero.ch/help/deposit/

The link of the table of content

  • are https://sonar.test.rero.ch/#publication-rights
  • should be https://sonar.test.rero.ch/help/deposit/#publication-rights
@sebdeleze sebdeleze added bug Breaks something but is not blocking dev: documentation About changelog, release notes, installation procedures, gh templates... labels Jan 29, 2021
@mmo
Copy link
Collaborator

mmo commented Feb 1, 2021

There is problem when opening the user menu, as it is overridden by the table of contents. In that case, the overridden options of the menu are not clickable (MacOS Safari).
Screenshot 2021-02-01 at 13 37 53

sebdeleze pushed a commit that referenced this issue Feb 2, 2021
* Fixes links in table of contents by adding a `base href` tag into the page.
* Decreases z-index of TOC to make it appear below the user's dropdown menu.
* Closes #450.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking dev: documentation About changelog, release notes, installation procedures, gh templates...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants