Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the label of the main file in the document detailed view #732

Closed
mmo opened this issue Dec 7, 2021 · 0 comments · Fixed by #780
Closed

Hide the label of the main file in the document detailed view #732

mmo opened this issue Dec 7, 2021 · 0 comments · Fixed by #780
Assignees
@Garfield-fr
Labels
enhancement Enhancement of an existing feature f: professional ui f: public ui p-Medium To set a medium priority.
Milestone
v1.6.0

Comments

@mmo
Copy link
Collaborator

mmo commented Dec 7, 2021 •
edited by pronguen
Loading

Current problem

This label cannot be defined when depositing the document (first deposit step) and it is displayed as is in the public interface.

Context: We hid this field on purpose from the deposit editor. In RERO DOC, this label was problematic because it varied slightly from document to document and was not translated (examples: "main file", "Main file", "Full text", "plein texte", etc.).

image

Expected

Hide the label in

  • document detailed view - public interface
  • document detailed view - professional interface

The end user does not need any label for the main file. He/She only need one to identify and distinguish the "other files".
@pronguen pronguen added the p-Low To set a low priority. label Dec 7, 2021
@pronguen pronguen changed the title deposit: add a field corresponding to the file label _files[].label Hide the label of the main file in the document detailed view Feb 10, 2022
@pronguen pronguen added f: professional ui f: public ui p-Medium To set a medium priority. and removed p-Low To set a low priority. labels Feb 10, 2022
@Garfield-fr Garfield-fr self-assigned this Feb 16, 2022
Garfield-fr added a commit to Garfield-fr/sonar that referenced this issue Feb 16, 2022
@Garfield-fr
documents: hide label file in the detailed view
488d574 
* Closes rero#732.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Feb 16, 2022
Merged
7 tasks
@pronguen pronguen added the enhancement Enhancement of an existing feature label Feb 18, 2022
Garfield-fr added a commit that referenced this issue Feb 24, 2022
@Garfield-fr
documents: hide label file in the detailed view
4bd9545 
* Closes #732.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@PascalRepond PascalRepond added this to the v1.6.0 milestone Feb 28, 2022
Garfield-fr added a commit that referenced this issue Mar 1, 2022
@Garfield-fr
documents: hide label file in the detailed view
893ce0a 
* Closes #732.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
enhancement Enhancement of an existing feature f: professional ui f: public ui p-Medium To set a medium priority.
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

documents: hide label file in the detailed view Garfield-fr/sonar
4 participants
@Garfield-fr @mmo @pronguen @PascalRepond