Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

organisation: improve organisation editor #200

Merged
merged 1 commit into from
May 19, 2020
Merged

organisation: improve organisation editor #200

merged 1 commit into from
May 19, 2020

Conversation

sebdeleze
Copy link
Contributor

@sebdeleze sebdeleze commented Apr 22, 2020 •
edited
Loading

  • Moves organisation code from "pid" to "code" field.
  • Configures JSON schema for improving organisation editor.
  • Adds a method to retrieve organisation by its code in OrganisationRecord.
  • Renames tests file and folder containing "institution".
  • Removes useless registered_organisations property from Overdo class.
  • Closes Improves organisation editor, as an organization cannot be added. sonar-ui#64.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

How to test

  1. Login as an administrator.
  2. Go to Admin -> Records -> Organisations.
  3. Click Add button.
  4. Fill the form and check field requirements and validations.
  5. Save organisation.
  6. Edit organisation and change some fields.
  7. Save organisation.
  8. Delete organisation.

@sebdeleze sebdeleze marked this pull request as ready for review April 22, 2020 12:38
@sebdeleze sebdeleze requested a review from jma April 22, 2020 13:08
@sebdeleze sebdeleze marked this pull request as draft April 24, 2020 06:04
@sebdeleze sebdeleze removed the request for review from jma April 24, 2020 06:04
@sebdeleze sebdeleze marked this pull request as ready for review April 24, 2020 08:53
@sebdeleze sebdeleze requested a review from jma May 6, 2020 09:52
jma
jma approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you add the notion of organisation code. Is can be also a persistant identifiers?

@sebdeleze
Copy link
Contributor Author

@jma It was the persistent identifier, but I changed this in this PR. The reason is when we want to add a new organisation, the PID was filled and it caused an error because API understand the request as a PUT and not a POST.
Moreover, it seems to me that it is also stored in a specific property in RERO-ILS, so I wanted to keep a consistency.
We can discuss about that before merging, if you want.

organisation: improve organisation editor
9c03104 
* Stores organisation code in "code" field.
* Guesses organisation PID from "code" field.
* Configures JSON schema for improving organisation editor.
* Renames tests file and folder containing "institution".
* Closes #223.
* Closes rero/sonar-ui#64.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit dbd3371 into rero:dev May 19, 2020
@sebdeleze sebdeleze deleted the sed-org-editor branch May 19, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improves organisation editor, as an organization cannot be added.
2 participants
@sebdeleze @jma