Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user: improve editor #202

Merged
merged 1 commit into from
May 13, 2020
Merged

user: improve editor #202

merged 1 commit into from
May 13, 2020

Conversation

sebdeleze
Copy link
Contributor

@sebdeleze sebdeleze commented Apr 24, 2020

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

How to test

  1. Login as an administrator.
  2. Go to Admin -> Records -> Users.
  3. Click Add button.
  4. Fill the form and check field requirements and validations.
  5. Save user.
  6. Edit user and change some fields.
  7. Save user.
  8. Delete user.

!!! Warning, when adding a user, there's sometimes an error because the redirection is too fast. This must be corrected in ng-core rero/ng-core#179. Simply refresh the page to view created user details.

@sebdeleze sebdeleze marked this pull request as ready for review April 24, 2020 09:43
@sebdeleze sebdeleze requested a review from zannkukai May 6, 2020 09:51
@sebdeleze sebdeleze requested a review from zannkukai May 7, 2020 07:21
* Configures JSON schema for improving user editor.
* Updates fields in marshmallow for serialization and loading.
* Closes rero/sonar-ui#65.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit 6f8dc46 into rero:dev May 13, 2020
@sebdeleze sebdeleze deleted the sed-user-editor branch May 13, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improves user editor:
2 participants