Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

organisations: access records with specific URL #234

Merged
merged 1 commit into from
Jun 17, 2020
Merged

organisations: access records with specific URL #234

merged 1 commit into from
Jun 17, 2020

Conversation

sebdeleze
Copy link
Contributor

@sebdeleze sebdeleze commented May 29, 2020 •
edited
Loading

  • Adds a property isShared in organisation to allow access to records by a specific URL.
  • Adds a property isDedicated in organisation to allow organisation to have a specific theme and logo.
  • Adds a specific route to document details instead of built-in invenio view.
  • Adds a method to get current view code in templates.
  • Renames ir query parameter to view for consistency.
  • Stores current organisation record in Flask globals.
  • Adds a header containing current organisation information in templates.
  • Checks if organisation is flagged as dedicated for including custom logo and styles.
  • Closes Possibility to access records for an organisation with a specific URL #216.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

How to test

Shared repository

  1. Try to access /organisation/unisi --> Error is thrown.
  2. Login as superuser.
  3. Edit unisi organisation and check option "Is shared".
  4. Try to access /organisation/unisi --> Is accessible.

Dedicated.

  1. Login as superuser.
  2. Edit unisi organisation and check option "Is shared" and "Is dedicated".
  3. Go to /organisation/unisi --> Page should have a custom theme.

@sebdeleze sebdeleze marked this pull request as ready for review May 29, 2020 07:42
@sebdeleze sebdeleze mentioned this pull request Jun 12, 2020
Merged
@sebdeleze sebdeleze requested a review from jma June 16, 2020 08:25
jma
jma requested changes Jun 17, 2020
View reviewed changes
sonar/modules/documents/views.py Show resolved Hide resolved
sonar/theme/templates/sonar/partial/navbar.html Outdated Show resolved Hide resolved
organisations: access records with specific URL
37060f8 
* Adds a property `isShared` in organisation to allow access to records by a specific URL.
* Adds a property `isDedicated` in organisation to allow organisation to have a specific theme and logo.
* Adds a specific route to document details instead of built-in invenio view.
* Adds a method to get current view code in templates.
* Renames `ir` query parameter to `view` for consistency.
* Stores current organisation record in Flask globals.
* Adds a header containing current organisation information in templates.
* Checks if organisation is flagged as dedicated for including custom logo and styles.
* Closes #216.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze requested a review from jma June 17, 2020 11:51
@sebdeleze sebdeleze merged commit d9b6761 into rero:dev Jun 17, 2020
@sebdeleze sebdeleze deleted the sed-org-view branch June 17, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibility to access records for an organisation with a specific URL
2 participants
@sebdeleze @jma