Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: import start date from field 502$9. #262

Merged
merged 1 commit into from
Aug 17, 2020
Merged

documents: import start date from field 502$9. #262

merged 1 commit into from
Aug 17, 2020

Conversation

sebdeleze
Copy link
Contributor

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review July 17, 2020 12:46
@sebdeleze sebdeleze requested a review from blankoworld July 17, 2020 12:46
@pronguen pronguen self-requested a review July 20, 2020 14:11
Copy link
Contributor

@pronguen pronguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thesis that is imported into sonardev is the following:
https://sonardev.test.rero.ch/global/documents/9
I cannot see its date, so I cannot test 😬

@pronguen
Copy link
Contributor

The only thesis that is imported into sonardev is the following:
https://sonardev.test.rero.ch/global/documents/9
I cannot see its date, so I cannot test 😬

It is actually a display problem. We should:

  • display the dissertation field on document detailed view
  • display the dissertation field on document brief view
  • this field should be completed by two subfields as in spec: grantingInstitution, date. I just renamed subfield note into jury_note (not urgent, just not to confuse it with usual notes).
  • this field and all its subfields should be displayed in the deposit form for doc type = dissertation (or dissertation subtype).

I adapted the mockup accordingly on Switchdrive: sonar_shared\WP3_user_interface\mockups\search_v4.pdf

@sebdeleze
Copy link
Contributor Author

The only thesis that is imported into sonardev is the following:
https://sonardev.test.rero.ch/global/documents/9
I cannot see its date, so I cannot test 😬

You can now see the date!

* Imports start date in provision activity from field `502$9`.
* Prioritizes fields for retreiving start date: 1. 260$c, 2. 269$c, 3. 773$g, 4. 502$9.
* Fixes display of start date in detail views.
* Closes #254.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit a221c03 into rero:dev Aug 17, 2020
@sebdeleze sebdeleze deleted the sed-import-dates branch August 17, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract date during import of documents
3 participants