Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: improve editor #281

Merged
merged 1 commit into from
Sep 7, 2020
Merged

documents: improve editor #281

merged 1 commit into from
Sep 7, 2020

Conversation

sebdeleze
Copy link
Contributor

@sebdeleze sebdeleze commented Aug 21, 2020

Improve document editor by making some changes on fields, listed below.

  • Adds CSS class editor-title to display a block for each main fields.
  • Makes field title.type not editable and place it after the value.
  • Removes type bf:Local for contribution field.
  • Makes field classification.type not editable and place it after the value.
  • Shows value when a subtitle field is added.
  • Makes language field required and language.type readonly.
  • Makes partof field required when document type is a contribution to journal.
  • Makes organisation field required.
  • Makes provisionActivity field required depending on document type, instead of hiding it.
  • Closes Improve and correct the document editor #230.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze requested a review from zannkukai August 21, 2020 10:34
@sebdeleze sebdeleze marked this pull request as ready for review August 21, 2020 10:34
@pronguen
Copy link
Contributor

pronguen commented Aug 27, 2020

For type "Contribution to journal" (c_3e5a), subfields are missing and impossible to add to partOf (numberingVolume, numberingIssue). There should be the same subfields than for "Scientific article".

image

There are 2 trashes for the field editionStatement

image

What is the base date field (so that we can build the year facet)? I think it is provisionActivity.startDate (if type=bf:Publication). This should be required in any document... I am sorry, spec were not clear. If we display provisionActivity.startDate all the time (as specified in #254), this field must be required, right?

For a book chapter, I should be able to add a startDate in the partOf, but the select option is empty.

image

@sebdeleze
Copy link
Contributor Author

For type "Contribution to journal" (c_3e5a), subfields are missing and impossible to add to partOf (numberingVolume, numberingIssue). There should be the same subfields than for "Scientific article".

Corrected.

There are 2 trashes for the field editionStatement

Corrected.

What is the base date field (so that we can build the year facet)? I think it is provisionActivity.startDate (if type=bf:Publication). This should be required in any document... I am sorry, spec were not clear. If we display provisionActivity.startDate all the time (as specified in #254), this field must be required, right?

Yes this is the provisionActivity.startDate which is taken for populating the year facet. Ok, by now, this field is required all the time.

For a book chapter, I should be able to add a startDate in the partOf, but the select option is empty.

That's an issue with the editor. I created rero/ng-core#247 for @jma.

Improve document editor by making some changes on fields, listed below.

* Adds CSS class `editor-title` to display a block for each main fields.
* Makes field `title.type` not editable and place it after the value.
* Removes type `bf:Local` for `contribution` field.
* Makes field `classification.type` not editable and place it after the value.
* Shows value when a `subtitle` field is added.
* Makes `language` field required and `language.type` readonly.
* Makes `partof` field required when document type is a contribution to journal.
* Makes `organisation` field required.
* Makes `provisionActivity` field required depending on document type, instead of hiding it.
* Closes #230.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@mmo
Copy link
Collaborator

mmo commented Sep 7, 2020

Seems ok, but not thoroughly tested.

@sebdeleze sebdeleze merged commit 6831f07 into rero:dev Sep 7, 2020
@sebdeleze sebdeleze deleted the sed-improve-editor branch September 7, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve and correct the document editor
4 participants