Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: export records in Dublic Core format #340

Merged
merged 1 commit into from
Nov 12, 2020
Merged

documents: export records in Dublic Core format #340

merged 1 commit into from
Nov 12, 2020

Conversation

sebdeleze
Copy link
Contributor

This PR configures OAI server to export documents records in Dublin Core formats.

  • Installs dcxml library to generate the output in Dublic CORE XML.
  • Creates and configures the serializer for oai_dc format.
  • Dumps mimetype from file object to record's file metadata.
  • Adds a serializer schema for Dublic Core.
  • Adds mimetype property to all resources that use files.
  • Avoids to display issue and pages if volume is not defined in partOf property.
  • Closes OAI-PMH Export format in Dublin Core (DC) #325.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review October 12, 2020 11:21
@pronguen
Copy link
Contributor

pronguen commented Nov 10, 2020

Thank you, this is a big step forwards!

In this state, the data is already completely usable! Here what can still be improved:

  • in dc:source, the data from [partOf.document.numberingPages] is missing (and maybe also number, volume...)
    • apparently, it is missing when I remove the volume. I think this comes from the spec that are not clear (If possible display "vol.", "nr." etc. only if a volume exists.). We should display the prefix "vol." only if this field exist, the prefix "nr." only if this field exist, the prefix "p." only if this field exist. Sorry!
    • This correction can be done later in an issue (just tell me to open the issue)

image

  • in dc:rights, the value does not change if the file is embargoed, restricted or not. It should change.
    • works fine now 👌
  • in dc:subject the classification is missing
    • works fine now 👌

@sebdeleze
Copy link
Contributor Author

Thank you, this is a big step forwards!

In this state, the data is already completely usable! Here what can still be improved:

  • in dc:source, the data from [partOf.document.numberingPages] is missing (and maybe also number, volume...)

    • apparently, it is missing when I remove the volume. I think this comes from the spec that are not clear (If possible display "vol.", "nr." etc. only if a volume exists.). We should display the prefix "vol." only if this field exist, the prefix "nr." only if this field exist, the prefix "p." only if this field exist. Sorry!
    • This correction can be done later in an issue (just tell me to open the issue)

Yes, you can create an issue as it's not fully related to this PR.

This PR configures OAI server to export documents records in Dublin Core formats.

* Installs `dcxml` library to generate the output in Dublic CORE XML.
* Creates and configures the serializer for `oai_dc` format.
* Dumps `mimetype` from file object to record's file metadata.
* Adds a serializer schema for Dublic Core.
* Adds `mimetype` property to all resources that use files.
* Avoids to display issue and pages if volume is not defined in `partOf` property.
* Adds a custom serializers for dumping DC objects.
* Closes #325.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit 1a5799e into rero:dev Nov 12, 2020
@sebdeleze sebdeleze deleted the sed-oai-export-dc branch November 12, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAI-PMH Export format in Dublin Core (DC)
2 participants