Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documents: add a back button in detail views #384

Merged
merged 1 commit into from
Dec 15, 2020
Merged

documents: add a back button in detail views #384

merged 1 commit into from
Dec 15, 2020

Conversation

sebdeleze
Copy link
Contributor

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review November 30, 2020 07:30
@pronguen
Copy link
Contributor

pronguen commented Dec 14, 2020 •
edited
Loading

The button works well!

  • It could be added to the project detailed view as well
  • Eventually harmonise between pro/public interface

Harmonisation:
In the professional interface, "Back" is a link; in the public interface, it is a button. It would be great to harmonise. Moreover, they are in two different locations (top and bottom of the detailed view).
@mmo @iGormilhit What do you think: should it be a link or a button?

Personally, I think the link is more appropriate

  • as it is not an action but a way to another page
  • as it is more discreet ("back" should not be a call to action, should not get the attention)
  • location: top left

@iGormilhit
Copy link

I'm also in favor of the link.

@mmo
Copy link
Collaborator

mmo commented Dec 14, 2020

After some tests, I agree with all the comments by @pronguen.

documents: add a back button in detail views
3764c65 
* Adds a button to go back to search results in documents detail views.
* Reduces the size of `Back to SONAR` button in organisation's context.
* Closes #383.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@pronguen pronguen self-requested a review December 15, 2020 07:50
@sebdeleze sebdeleze merged commit 47070cf into rero:dev Dec 15, 2020
@sebdeleze sebdeleze deleted the sed-back-button branch December 15, 2020 15:54
@sebdeleze sebdeleze added design f: editor Concerns editor based on JSON schema AND custom editor enhancement Enhancement of an existing feature labels Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pronguen pronguen pronguen approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A "Back to results" button is missing in the detailed record view
5 participants
@sebdeleze @pronguen @iGormilhit @mmo @Garfield-fr