Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch to GitHub Actions #436

Merged
merged 1 commit into from
Jan 12, 2021
Merged

ci: switch to GitHub Actions #436

merged 1 commit into from
Jan 12, 2021

Conversation

sebdeleze
Copy link
Contributor

  • Adds a file to configure continuous integration with GitHub Actions.
  • Adds a pull request template file.
  • Adds an issue template file.
  • Removes useless Travis configuration file.
  • Adjusts tests as the embargo date has been reached now.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review January 11, 2021 15:07
@sebdeleze sebdeleze requested a review from rerowep January 11, 2021 15:07
on: [push, pull_request, workflow_dispatch]

env:
TERM: xterm-256color
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need a TERM variable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I use tput to display messages in the bash scripts

.github/workflows/continuous-integration-test.yml Outdated Show resolved Hide resolved

- uses: actions/checkout@v2

- name: Install Libraries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the library installation not done in bootstrap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is libraries for Ubuntu like ImageMagick and no they're not installed in the bootstrap script.

.github/workflows/continuous-integration-test.yml Outdated Show resolved Hide resolved
* Adds a file to configure continuous integration with GitHub Actions.
* Adds a pull request template file.
* Adds an issue template file.
* Updates badge for CI in README file.
* Removes useless Travis configuration file.
* Adjusts tests as the embargo date has been reached now.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze requested a review from rerowep January 11, 2021 19:17
@sebdeleze sebdeleze merged commit 2d42412 into rero:dev Jan 12, 2021
@sebdeleze sebdeleze deleted the sed-github-actions branch January 12, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants