Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documents: custom fields for documents #525

Merged
merged 1 commit into from
May 25, 2021
Merged

documents: custom fields for documents #525

merged 1 commit into from
May 25, 2021

Conversation

sebdeleze
Copy link
Contributor

  • Adds the support of custom fields for dedicated organisations documents.
  • Adds the filters and aggregations for the custom fields.
  • Creates a custom class for managing JSON schemas, with a factory to instantiate the right class.
  • Configures JSON schema and Elasticsearch mapping for the three custom fields.
  • Adjusts facets for custom fields depending on the context (dedicated view or not).
  • Displays the custom fields in documents detail view.
  • Adds properties in organisation (JSON schema and mapping) to configure the behavior of the custom fields.
  • Refactors the view serving the JSON schema, to use the new class and factory.
  • Closes Allow the definition of custom metadata fields and facets [5] #512.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review April 14, 2021 14:40
@sebdeleze sebdeleze requested a review from jma April 23, 2021 15:41
jma
jma approved these changes May 4, 2021
View reviewed changes
sonar/json_schemas/factory.py Outdated Show resolved Hide resolved
sonar/json_schemas/json_schema.py Outdated Show resolved Hide resolved
sonar/json_schemas/json_schema.py Outdated Show resolved Hide resolved
sonar/json_schemas/json_schema.py Outdated Show resolved Hide resolved
sonar/json_schemas/json_schema.py Outdated Show resolved Hide resolved
sonar/modules/organisations/jsonschemas/organisations/organisation-v1.0.0_src.json Show resolved Hide resolved
sonar/modules/organisations/jsonschemas/organisations/organisation-v1.0.0_src.json Show resolved Hide resolved
sonar/modules/utils.py Outdated Show resolved Hide resolved
sonar/modules/utils.py Outdated Show resolved Hide resolved
tests/unit/json_schemas/test_json_schema.py Outdated Show resolved Hide resolved
documents: custom fields for documents
5615244 
* Adds the support of custom fields for dedicated organisations documents.
* Adds the filters and aggregations for the custom fields.
* Creates a custom class for managing JSON schemas, with a factory to instantiate the right class.
* Configures JSON schema and Elasticsearch mapping for the three custom fields.
* Adjusts facets for custom fields depending on the context (dedicated view or not).
* Displays the custom fields in documents detail view.
* Adds properties in organisation (JSON schema and mapping) to configure the behavior of the custom fields.
* Refactors the view serving the JSON schema, to use the new class and factory.
* Closes #512.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit 525f586 into rero:staging May 25, 2021
@sebdeleze sebdeleze deleted the sed-custom-documents-fields branch May 25, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow the definition of custom metadata fields and facets [5]
2 participants
@sebdeleze @jma