Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: flag record as harvested #557

Merged
merged 1 commit into from
May 12, 2021
Merged

documents: flag record as harvested #557

merged 1 commit into from
May 12, 2021

Conversation

sebdeleze
Copy link
Contributor

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review May 10, 2021 08:54
@sebdeleze sebdeleze requested a review from jma May 10, 2021 08:54
* Flags record as `harvested` when it is imported from an external source.
* Closes #556.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze requested a review from zannkukai May 11, 2021 12:50
@@ -101,6 +101,7 @@ class DocumentMetadataSchemaV1(StrictKeysMixin):
oa_status = SanitizedUnicode()
hiddenFromPublic = fields.Boolean()
sections = fields.List(fields.Str())
harvested = fields.Boolean()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a default_value=False ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tendency is rather not to serialize the property if it does not exist.

@sebdeleze sebdeleze merged commit 6e118a9 into rero:staging May 12, 2021
@sebdeleze sebdeleze deleted the sed-record-mark-harvested branch May 12, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark documents as harvested when they are import from an external source
4 participants