Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: aggregations order endpoint #645

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

jma
Copy link
Contributor

@jma jma commented Sep 9, 2021

  • Adds an endpoint to get the aggregations order for the documents.
  • Moves logic for displaying facets into the new endpoint instead of
    the search serializer.
  • Closes Display facets depending on context #623.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma requested a review from mmo September 9, 2021 05:16
@jma jma marked this pull request as ready for review September 9, 2021 05:16
@iGormilhit iGormilhit added the f: search Elasticseach configuration, result page, facets label Sep 9, 2021
* Adds an endpoint to get the aggregations order for the documents.
* Moves logic for displaying facets into the new endpoint instead of
the search serializer.
* Closes rero#623.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@jma jma force-pushed the sed-doc-aggs-order branch from d75d1c5 to dabac3c Compare September 9, 2021 09:05
@mmo mmo merged commit a268ce2 into rero:staging Sep 9, 2021
@jma jma deleted the sed-doc-aggs-order branch February 7, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: search Elasticseach configuration, result page, facets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display facets depending on context
3 participants