Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application: fix responsive design menu #685

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

Garfield-fr
Copy link
Contributor

Why are you opening this PR?

  • In mobile, the main menu button is inactive.

How to test?

  • Check hamburger menu

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr self-assigned this Nov 2, 2021
@Garfield-fr Garfield-fr force-pushed the zub-fix-responsive-menu branch from 1237c8c to a2c8402 Compare November 3, 2021 06:26
* Closes rero#667.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-fix-responsive-menu branch from a2c8402 to cabc9b0 Compare November 3, 2021 09:47
@Garfield-fr Garfield-fr requested review from jma, mmo and vgranata November 3, 2021 09:47
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand but seems nice...

@jma jma merged commit 93c50ea into rero:staging Nov 4, 2021
@Garfield-fr Garfield-fr deleted the zub-fix-responsive-menu branch November 29, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix responsive menu (TEST env) [2]
2 participants