es: index both ISBN 10 and 13 format

* closes: rero#1486 Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep · Feb 1, 2021 · a274c00 · a274c00
1 parent 45722af
commit a274c00
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 16 deletions.
diff --git a/rero_ils/modules/documents/listener.py b/rero_ils/modules/documents/listener.py
@@ -17,6 +17,8 @@
 
 """Signals connector for Document."""
 
+from isbnlib import is_isbn10, is_isbn13, to_isbn10, to_isbn13
+
 from .utils import create_contributions, title_format_text_head
 from ..documents.api import Document, DocumentsSearch
 from ..holdings.api import Holding, HoldingsSearch
@@ -156,3 +158,22 @@ def enrich_document_data(sender, json=None, record=None, index=None,
             'doc', document_pid)
         if local_fields:
             json['local_fields'] = local_fields
+        # index both ISBN 10 and 13 format
+
+        def filter_isbn(identified_by):
+            """Filter identified_by for type bf:Isbn."""
+            return identified_by.get('type') == 'bf:Isbn'
+
+        filtered_identified_by = filter(
+            filter_isbn,
+            json.get('identifiedBy', [])
+        )
+        isbns = set()
+        for identified_by in filtered_identified_by:
+            isbn = identified_by['value']
+            isbns.add(isbn)
+            if is_isbn10(isbn):
+                isbns.add(to_isbn13(isbn))
+            elif is_isbn13(isbn):
+                isbns.add(to_isbn10(isbn))
+        json['isbn'] = list(isbns)
diff --git a/rero_ils/modules/documents/mappings/v7/documents/document-v0.0.1.json b/rero_ils/modules/documents/mappings/v7/documents/document-v0.0.1.json
@@ -919,6 +919,9 @@
       "harvested": {
         "type": "boolean"
       },
+      "isbn": {
+        "type": "keyword"
+      },
       "_draft": {
         "type": "boolean"
       },

diff --git a/tests/ui/documents/test_documents_mapping.py b/tests/ui/documents/test_documents_mapping.py
@@ -51,30 +51,36 @@ def test_document_search_mapping(app, document_records):
     """Test document search mapping."""
     search = DocumentsSearch()
 
-    c = search.query('query_string', query='reine Berthe').count()
-    assert c == 2
+    count = search.query('query_string', query='reine Berthe').count()
+    assert count == 2
 
-    c = search.query('query_string', query='maison').count()
-    assert c == 1
+    count = search.query('query_string', query='maison').count()
+    assert count == 1
 
-    c = search.query('query_string', query='scene').count()
-    assert c == 1
+    count = search.query('query_string', query='scene').count()
+    assert count == 1
 
     query = MultiMatch(query='scène', fields=['abstracts.fre'])
-    c = search.query(query).count()
-    assert c == 1
+    count = search.query(query).count()
+    assert count == 1
 
-    c = search.query('query_string', query='Körper').count()
-    assert c == 1
+    count = search.query('query_string', query='Körper').count()
+    assert count == 1
 
     query = MultiMatch(query='Körper', fields=['abstracts.ger'])
-    c = search.query(query).count()
-    assert c == 1
+    count = search.query(query).count()
+    assert count == 1
 
-    c = search.query('query_string', query='Chamber Secrets').count()
-    assert c == 1
+    count = search.query('query_string', query='Chamber Secrets').count()
+    assert count == 1
 
     query = MultiMatch(query='Chamber of Secrets',
                        fields=['title._text.*'])
-    c = search.query(query).count()
-    assert c == 1
+    count = search.query(query).count()
+    assert count == 1
+
+    count = search.query('query_string', query='9782823855890').count()
+    assert count == 1
+
+    count = search.query('query_string', query='2823855890').count()
+    assert count == 1