Fix: make sure Tree::ui allocates the space it uses in parent Ui
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rydb
changed the title
emilk
reviewed
Jun 3, 2024
src/tree.rs
Outdated
| @@ -264,6 +264,8 @@ impl<Pane> Tree<Pane> { | |||
| } | |||
|
|
|||
| self.preview_dragged_tile(behavior, &drop_context, ui); | |||
| // resizes the window to fit the ui. | |||
| ui.allocate_space(ui.available_size()); | |||
There was a problem hiding this comment.
We use ui.available_rect_before_wrap() earlier.
Save that rect instead, then use ui.advance_cursor_after_rect(rect); here
There was a problem hiding this comment.
ah, didn't notice that. changed pr to re-use rect.
emilk
reviewed
Jun 5, 2024
done |
emilk
changed the title
Tree::ui allocates the space it uses in parent Ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered in
#69
that the window of a tree ui does not fully fit inside the window by default. This pr fixes that issue by adding
to the end of
tree.ui().