Skip to content

Commit

Permalink
Remove benches and tests related to parquet
Browse files Browse the repository at this point in the history
  • Loading branch information
emilk committed Jan 15, 2024
1 parent b64879d commit 91ef392
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 210 deletions.
8 changes: 0 additions & 8 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -339,14 +339,6 @@ name = "comparison_kernels"
harness = false


[[bench]]
name = "read_parquet"
harness = false

[[bench]]
name = "write_parquet"
harness = false

[[bench]]
name = "aggregate"
harness = false
Expand Down
102 changes: 0 additions & 102 deletions benches/read_parquet.rs

This file was deleted.

72 changes: 0 additions & 72 deletions benches/write_parquet.rs

This file was deleted.

45 changes: 23 additions & 22 deletions src/doc/lib.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use re_arrow2::array::*;
use re_arrow2::datatypes::{Field, DataType, Schema};
use re_arrow2::compute::arithmetics;
use re_arrow2::error::Result;
use re_arrow2::io::parquet::write::*;
// use re_arrow2::io::parquet::write::*;
use re_arrow2::chunk::Chunk;

fn main() -> Result<()> {
Expand All @@ -36,32 +36,33 @@ fn main() -> Result<()> {
// declare chunk
let chunk = Chunk::new(vec![a.arced(), b.arced()]);

// write to parquet (probably the fastest implementation of writing to parquet out there)
// // write to parquet (probably the fastest implementation of writing to parquet out there)

let options = WriteOptions {
write_statistics: true,
compression: CompressionOptions::Snappy,
version: Version::V1,
data_pagesize_limit: None,
};
// let options = WriteOptions {
// write_statistics: true,
// compression: CompressionOptions::Snappy,
// version: Version::V1,
// data_pagesize_limit: None,
// };

let row_groups = RowGroupIterator::try_new(
vec![Ok(chunk)].into_iter(),
&schema,
options,
vec![vec![Encoding::Plain], vec![Encoding::Plain]],
)?;
// let row_groups = RowGroupIterator::try_new(
// vec![Ok(chunk)].into_iter(),
// &schema,
// options,
// vec![vec![Encoding::Plain], vec![Encoding::Plain]],
// )?;

// anything implementing `std::io::Write` works
let mut file = vec![];
// // anything implementing `std::io::Write` works
// let mut file = vec![];

let mut writer = FileWriter::try_new(file, schema, options)?;
// let mut writer = FileWriter::try_new(file, schema, options)?;

// // Write the file.
// for group in row_groups {
// writer.write(group?)?;
// }
// let _ = writer.end(None)?;

// Write the file.
for group in row_groups {
writer.write(group?)?;
}
let _ = writer.end(None)?;
Ok(())
}
```
Expand Down
12 changes: 6 additions & 6 deletions tests/it/io/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@ mod json;
#[cfg(feature = "io_json")]
mod ndjson;

#[cfg(feature = "io_json_integration")]
mod ipc;
// #[cfg(feature = "io_json_integration")] // disabled: requiers test data
// mod ipc; // disabled: requiers test data

#[cfg(feature = "io_parquet")]
mod parquet;

#[cfg(feature = "io_avro")]
mod avro;

#[cfg(feature = "io_orc")]
mod orc;
// #[cfg(feature = "io_orc")] // disabled: requiers test data
// mod orc; // disabled: requiers test data

#[cfg(any(
feature = "io_csv_read",
Expand All @@ -26,5 +26,5 @@ mod orc;
))]
mod csv;

#[cfg(feature = "io_flight")]
mod flight;
// #[cfg(feature = "io_flight")] // disabled: requiers test data
// mod flight; // disabled: requiers test data

0 comments on commit 91ef392

Please sign in to comment.