Skip to content

Commit

Permalink
Datatype deduplication 1: remove polars (#4880)
Browse files Browse the repository at this point in the history
All the grunt work left to get rid of polars.

- Remove all helpers and APIs built specifically for polars'
`DataFrame`.
- Refactor tests that rely on dataframe joins to not require join
semantics in the first place (`re_data_store` has no knowledge of those
anyway).
- The one test that does require join semantics has moved over to
`re_query`, where join semantics belong.
- All `polars-*` dep have been removed.

Don't look at the commit log as it makes no sense: i changed strategies
a bunch of times on the way.

---

- Part of #4789
- DNR: requires #4856

---

Part of the tiny datatype deduplication PR series:
- #4880
- #4883
  • Loading branch information
teh-cmc authored Jan 23, 2024
1 parent 4444217 commit 80d52e9
Show file tree
Hide file tree
Showing 21 changed files with 267 additions and 2,230 deletions.
400 changes: 28 additions & 372 deletions Cargo.lock

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,6 @@ paste = "1.0"
pathdiff = "0.2"
pico-args = "0.5"
ply-rs = { version = "0.1", default-features = false }
polars-core = "0.29"
polars-lazy = "0.29"
polars-ops = "0.29"
poll-promise = "0.3"
pollster = "0.3"
prettyplease = "0.2"
Expand Down
51 changes: 1 addition & 50 deletions crates/re_data_store/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,13 @@ default = []
## Enables `parking_lot`'s deadlock detection background thread.
deadlock_detection = ["parking_lot/deadlock_detection"]

## Integration with `polars`, to efficiently use the datastore with dataframes.
polars = ["dep:polars-core", "dep:polars-ops"]


[dependencies]
# Rerun dependencies:
re_error.workspace = true
re_format = { workspace = true, features = ["arrow"] }
re_log_types.workspace = true
re_log.workspace = true
re_log = { workspace = true, features = ["setup"] }
re_tracing.workspace = true
re_types_core.workspace = true

Expand All @@ -48,38 +45,13 @@ smallvec.workspace = true
thiserror.workspace = true
web-time.workspace = true

# Optional dependencies:
polars-core = { workspace = true, optional = true, features = [
"diagonal_concat",
"dtype-date",
"dtype-datetime",
"dtype-time",
"dtype-struct",
"sort_multiple",
] }
polars-ops = { workspace = true, optional = true, features = [
"dtype-date",
"dtype-datetime",
"dtype-time",
"dtype-struct",
] }


[dev-dependencies]
re_types = { workspace = true, features = ["datagen", "testing"] }

anyhow.workspace = true
criterion.workspace = true
mimalloc.workspace = true
polars-core = { workspace = true, features = [
"diagonal_concat",
"dtype-date",
"dtype-datetime",
"dtype-struct",
"dtype-time",
"fmt",
"sort_multiple",
] }
rand.workspace = true
similar-asserts.workspace = true
tinyvec.workspace = true
Expand All @@ -88,27 +60,6 @@ tinyvec.workspace = true
bench = false


[[example]]
name = "dump_dataframe"
path = "examples/dump_dataframe.rs"
required-features = ["polars"]

[[example]]
name = "latest_component"
path = "examples/latest_component.rs"
required-features = ["polars"]

[[example]]
name = "latest_components"
path = "examples/latest_components.rs"
required-features = ["polars"]

[[example]]
name = "range_components"
path = "examples/range_components.rs"
required-features = ["polars"]


[[bench]]
name = "arrow2"
harness = false
Expand Down
77 changes: 0 additions & 77 deletions crates/re_data_store/examples/dump_dataframe.rs

This file was deleted.

57 changes: 0 additions & 57 deletions crates/re_data_store/examples/latest_component.rs

This file was deleted.

46 changes: 0 additions & 46 deletions crates/re_data_store/examples/latest_components.rs

This file was deleted.

100 changes: 0 additions & 100 deletions crates/re_data_store/examples/range_components.rs

This file was deleted.

Loading

0 comments on commit 80d52e9

Please sign in to comment.