Run snapshot tests everywhere but render/compare only on mac (#8252)

rerun-io · Dec 2, 2024 · 91dc5a9 · 91dc5a9
1 parent c9a1e42
commit 91dc5a9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/crates/viewer/re_time_panel/tests/time_panel_tests.rs b/crates/viewer/re_time_panel/tests/time_panel_tests.rs
@@ -12,7 +12,6 @@ use re_viewer_context::test_context::TestContext;
 use re_viewport_blueprint::ViewportBlueprint;
 
 #[test]
-#[cfg_attr(not(target_os = "macos"), ignore)]
 pub fn time_panel_two_sections_should_match_snapshot() {
     TimePanel::ensure_registered_subscribers();
     let mut test_context = TestContext::default();
@@ -38,7 +37,6 @@ pub fn time_panel_two_sections_should_match_snapshot() {
 }
 
 #[test]
-#[cfg_attr(not(target_os = "macos"), ignore)]
 pub fn time_panel_dense_data_should_match_snapshot() {
     TimePanel::ensure_registered_subscribers();
     let mut test_context = TestContext::default();
@@ -74,7 +72,7 @@ pub fn time_panel_dense_data_should_match_snapshot() {
     run_time_panel_and_save_snapshot(test_context, "time_panel_dense_data");
 }
 
-fn run_time_panel_and_save_snapshot(mut test_context: TestContext, snapshot_name: &str) {
+fn run_time_panel_and_save_snapshot(mut test_context: TestContext, _snapshot_name: &str) {
     let mut panel = TimePanel::default();
 
     //TODO(ab): this contains a lot of boilerplate which should be provided by helpers
@@ -105,5 +103,7 @@ fn run_time_panel_and_save_snapshot(mut test_context: TestContext, snapshot_name
 
     harness.run();
 
-    harness.wgpu_snapshot(snapshot_name);
+    //TODO(#8245): enable this everywhere when we have a software renderer setup
+    #[cfg(target_os = "macos")]
+    harness.wgpu_snapshot(_snapshot_name);
 }
diff --git a/crates/viewer/re_ui/tests/list_item_tests.rs b/crates/viewer/re_ui/tests/list_item_tests.rs
@@ -201,5 +201,7 @@ pub fn test_list_items_should_match_snapshot() {
 
     harness.run();
 
+    //TODO(#8245): enable this everywhere when we have a software renderer setup
+    #[cfg(target_os = "macos")]
     harness.wgpu_snapshot("list_items");
 }