-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving on Annotation Context (meta) #2405
Labels
enhancement
New feature or request
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current situation
ClassDescription
is a specific annotation: that attaches connection/colour semantics to the "keypoint" component of points2d/3dAnnotationInfo
is a (potentially generic?) low-level data structure used for storage of annotations such as ClassDescription.Possible improvements
Context
is both loaded and vague. We should try to find a better naming. "Annotation" (without "context") might be just as good, provided that the notion of "Annotation" is properly documented in "Concepts".ClassDescription
could have a better name as well. It pertains to keypoint ids, so its name should probably refer to that? Also, "Class" is rather loaded and best avoided in a Python SDK.AnnotationInfo
probably is a leaking implementation detail, and should disappear altogether from the API.ClassDescription
should have a better, more explicit API instead. I guess this could be addressed by HOPE.mp_face
example, were multiple sets of connection (which should have different colours) must be configured. This currently some manual work to create a "keypoint id -> class id" mapping and multipleClassDescription
objects.Bugs
The text was updated successfully, but these errors were encountered: