Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make AnnotationContext a multi-object of ClassDescriptions instead of a field #372

Closed
Wumpf opened this issue Nov 28, 2022 · 2 comments
Closed
Labels
🚜 refactor Change the code, not the functionality

Comments

@Wumpf
Copy link
Member

Wumpf commented Nov 28, 2022

Pro:

  • makes for a less confusing api: Right now one specifies the path an annotation context is added to whereas all (?) other things take a path that specifies where the logged object lives
  • allows to name your annotation context (right now it’s hardcoded to _annotation_context!)
  • makes it more straight forward fix ui issues from the keypoint api - we can then show keypoints only when a certain ClassDescription is displayed
  • “annotation context” goes away, it’s just “a bunch of ClassDescriptions”
  • paves the way for having multiple sets of class descriptors (I might have several kinds of class ids at once because I ran two classifies)

Con:

  • need to overhaul the way class descriptions are queried again, unclear to me how hard/easy
  • how hard is it to keep the table we have on annotation-context right now? need to query children when annotation context object is selected
  • annotations not being a property of a path might make it confusing when they apply
  • could do something else with precious time

Internal slack thread https://rerunio.slack.com/archives/C033K5VS2KD/p1669625884256649

@Wumpf
Copy link
Member Author

Wumpf commented Nov 28, 2022

work for this started on andreas/classdescriptors-as-object

@emilk emilk added the 🚜 refactor Change the code, not the functionality label Aug 8, 2023
@Wumpf
Copy link
Member Author

Wumpf commented Oct 31, 2023

this is very outdated by now. Lots has moved around there and

@Wumpf Wumpf closed this as completed Oct 31, 2023
@Wumpf Wumpf closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚜 refactor Change the code, not the functionality
Projects
None yet
Development

No branches or pull requests

2 participants