Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable codegen on Windows #2591

Closed
teh-cmc opened this issue Jul 3, 2023 · 2 comments
Closed

Re-enable codegen on Windows #2591

teh-cmc opened this issue Jul 3, 2023 · 2 comments
Labels
codegen/idl 🪟 windows Problems specific to the Windows OS

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jul 3, 2023 •
edited
Loading

Codegen (specifically, re_types_builder/build.rs & re_types/build.rs) has been disabled on Windows in #2592 because it was somehow computing different sha256 sums (??) and thus breaking the CI.

This isn't too bad of an issue as it only affects contributors on windows that are trying to modify IDL definitions but should nonetheless be fixed sooner than later.
@teh-cmc teh-cmc added 🪟 windows Problems specific to the Windows OS codegen/idl labels Jul 3, 2023
@teh-cmc teh-cmc mentioned this issue Jul 3, 2023
Merged
3 tasks
teh-cmc added a commit that referenced this issue Jul 3, 2023
@teh-cmc
Disable codegen on windows (#2592)
b964108 
See #2591:
> Codegen (specifically, `re_types_builder/build.rs` &
`re_types/build.rs`) has been disabled on Windows in #2592 because it
was somehow computing different sha256 sums (??) and thus breaking the
CI.
> 
> This isn't too bad of an issue as it only affects contributors on
windows that are trying to modify IDL definitions but should nonetheless
be fixed sooner than later.

### What

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{
pr.number }}) (if applicable)

- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/docs)
- [Examples preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/examples)
@jleibs
Copy link
Member

jleibs commented Oct 5, 2023

The sha-mismatch is likely another case where we are likely hitting line-ending inconsistencies introduced by git.

Also, when generating the files on windows we need to take care to normalize our path-separators. Running cargo codegen on windows now modifies the path comment in every file.

@emilk
Copy link
Member

emilk commented Feb 28, 2024

re_types/build.rs is gone, and the hashing is completely client-side (no hashes checked in), so I think this issue no longer applies.

@emilk emilk closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen/idl 🪟 windows Problems specific to the Windows OS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emilk @teh-cmc @jleibs