-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support light mode in the Rerun viewer #3058
Comments
The out of the box theme settings are bound to not work properly in rerun as we sadly change a lot of the theming colors in Rerun on-the-fly. At least I suspect that's what's most of the issue here. That said, (re)adding a light mode is something we want to do eventually. |
Thank you for your response. I'm currently in the process of developing an app using re_ui, and while the absence of a light mode isn't a critical issue, having that feature would certainly be a welcome addition. |
### Related * Part of/related to #3133 * Part of #3058 ### What This PR refactors the design token as follows: - All colors from `design_tokens.json` are now loaded in a big table at startup. - Colors are now referred to using the new the `ColorToken`, which is basically an index into this table. - Removed all of the color aliases stuff. This was only partially used and very cumbersome to update. The `design_token.rs` file is the _de facto_ source of truth of semantic aliasing for colors.
Hello,
I'm playing with .\rerun\crates\re_ui\examples\re_ui_example.rs and I'm trying to change the theme to light.
I have added only one line in the fn update:
Effect is strange: only central panel applies the theme. It can be seen in an attached video.
Any help would very appreciated.
2023-08-21.16-20-55.mp4
The text was updated successfully, but these errors were encountered: